morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-14 16:37:19 +09:00
Code Issues Packages Projects Releases Wiki Activity

test-routing-policy-rule: split out fd assignment from assert_se

Browse Source 
It's ugly that parentheses need to be used. Let's just split it out.
Incidentally, this will make coverity happy, because it doesn't grok
assert_se().
This commit is contained in:
Zbigniew Jędrzejewski-Szmek
2018-01-04 13:27:51 +01:00
parent 8ed7742aa2
commit 14899e2ba3
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/network/test-routing-policy-rule.c
View File

@@ -41,13 +41,15 @@ static void test_rule_serialization(const char *title, const char *ruleset, cons
log_info("========== %s ==========", title);
log_info("put:\n%s\n", ruleset);
assert_se((fd = mkostemp_safe(pattern)) >= 0);
fd = mkostemp_safe(pattern);
assert_se(fd >= 0);
assert_se(f = fdopen(fd, "a+e"));
assert_se(write_string_stream(f, ruleset, 0) == 0);
assert_se(routing_policy_load_rules(pattern, &rules) == 0);
assert_se((fd2 = mkostemp_safe(pattern2)) >= 0);
fd2 = mkostemp_safe(pattern2);
assert_se(fd2 >= 0);
assert_se(f2 = fdopen(fd2, "a+e"));
assert_se(routing_policy_serialize_rules(rules, f2) == 0);
@@ -57,7 +59,8 @@ static void test_rule_serialization(const char *title, const char *ruleset, cons
log_info("got:\n%s", buf);
assert_se((fd3 = mkostemp_safe(pattern3)) >= 0);
fd3 = mkostemp_safe(pattern3);
assert_se(fd3 >= 0);
assert_se(f3 = fdopen(fd3, "we"));
assert_se(write_string_stream(f3, expected ?: ruleset, 0) == 0);