core/mount: downgrade log level about several mkdir failures

This commit is contained in:
Yu Watanabe
2022-07-26 23:23:01 +09:00
parent e5e6b7c225
commit 574febda6b

View File

@@ -1053,9 +1053,13 @@ static void mount_enter_mounting(Mount *m) {
if (p && mount_is_bind(p)) {
r = mkdir_p_label(p->what, m->directory_mode);
/* mkdir_p_label() can return -EEXIST if the target path exists and is not a directory - which is
* totally OK, in case the user wants us to overmount a non-directory inode. */
* totally OK, in case the user wants us to overmount a non-directory inode. Also -EROFS can be
* returned on read-only filesystem. Moreover, -EACCES (and also maybe -EPERM?) may be returned
* when the path is on NFS. See issue #24120. All such errors will be logged in the debug level. */
if (r < 0 && r != -EEXIST)
log_unit_error_errno(UNIT(m), r, "Failed to make bind mount source '%s': %m", p->what);
log_unit_full_errno(UNIT(m),
(r == -EROFS || ERRNO_IS_PRIVILEGE(r)) ? LOG_DEBUG : LOG_WARNING,
r, "Failed to make bind mount source '%s', ignoring: %m", p->what);
}
if (p) {