morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-14 00:14:32 +09:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19117 from bluca/coverity

Browse Source 
Two small coverity issues
This commit is contained in:
Luca Boccassi
2021-03-25 19:33:58 +00:00
committed by GitHub
parent 8640566ac4 7489d0640a
commit 6f4c93259e
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/libsystemd-network/test-dhcp6-client.c
View File

@@ -449,6 +449,7 @@ static int test_advertise_option(sd_event *e) {
case SD_DHCP6_OPTION_IA_NA:
assert_se(optlen == 94);
assert_se(optval == &msg_advertise[26]);
assert_se(!memcmp(optval, &msg_advertise[26], optlen));
val = htobe32(0x0ecfa37d);

6
src/test/test-firewall-util.c
View File

@@ -14,6 +14,8 @@ static void test_v6(FirewallContext *ctx) {
uint8_t prefixlen;
int r;
assert_se(ctx);
log_info("/* %s(backend=%s) */", __func__, firewall_backend_to_string(ctx->backend));
if (!socket_ipv6_is_supported())
@@ -46,6 +48,7 @@ static void test_v6(FirewallContext *ctx) {
static union in_addr_union *parse_addr(const char *str, union in_addr_union *u) {
assert(str);
assert(u);
assert_se(in_addr_from_string(AF_INET, str, u) >= 0);
return u;
}
@@ -54,6 +57,8 @@ static bool test_v4(FirewallContext *ctx) {
union in_addr_union u, v;
int r;
assert_se(ctx);
log_info("/* %s(backend=%s) */", __func__, firewall_backend_to_string(ctx->backend));
assert_se(fw_add_masquerade(&ctx, true, AF_INET, NULL, 0) == -EINVAL);
@@ -92,6 +97,7 @@ int main(int argc, char *argv[]) {
return log_tests_skipped("not root");
assert_se(fw_ctx_new(&ctx) >= 0);
assert_se(ctx);
if (ctx->backend == FW_BACKEND_NONE)
return EXIT_TEST_SKIP;