morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-14 00:14:32 +09:00
Code Issues Packages Projects Releases Wiki Activity

pidref: various shortcuts to pidref_equal()

Browse Source 
This adds some shortcuts to pidref_equal(), so that we don't have to
query the pidfs id if there's no need.
This commit is contained in:
Lennart Poettering
2025-01-13 11:06:27 +01:00
parent 9ef559a036
commit 8110b34b64
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/basic/pidref.c
View File

@@ -40,6 +40,10 @@ int pidref_acquire_pidfd_id(PidRef *pidref) {
bool pidref_equal(PidRef *a, PidRef *b) {
/* If this is the very same structure, it definitely refers to the same process */
if (a == b)
return true;
if (!pidref_is_set(a))
return !pidref_is_set(b);
@@ -58,9 +62,15 @@ bool pidref_equal(PidRef *a, PidRef *b) {
if (a->fd_id == 0 || b->fd_id == 0)
return true;
} else {
/* If the other side is remote, then this is not the same */
if (pidref_is_remote(b))
return false;
/* PID1 cannot exit, hence it cannot change pidfs ids, hence no point in comparing them, we
* can shortcut things */
if (a->pid == 1)
return true;
/* Try to compare pidfds using their inode numbers. This way we can ensure that we
* don't spuriously consider two PidRefs equal if the pid has been reused once. Note
* that we ignore all errors here, not only EOPNOTSUPP, as fstat() might fail due to