cgroup-util: add remoteness checks to all cg_pidref_get_xyz() calls

This commit is contained in:
Lennart Poettering
2025-01-06 09:54:13 +01:00
parent 1740d3e04b
commit dd445d6e99
2 changed files with 6 additions and 2 deletions

View File

@@ -839,6 +839,8 @@ int cg_pidref_get_path(const char *controller, const PidRef *pidref, char **ret_
if (!pidref_is_set(pidref))
return -ESRCH;
if (pidref_is_remote(pidref))
return -EREMOTE;
r = cg_pid_get_path(controller, pidref->pid, &path);
if (r < 0)
@@ -1204,6 +1206,8 @@ int cg_pidref_get_unit(const PidRef *pidref, char **ret) {
if (!pidref_is_set(pidref))
return -ESRCH;
if (pidref_is_remote(pidref))
return -EREMOTE;
r = cg_pid_get_unit(pidref->pid, &unit);
if (r < 0)

View File

@@ -210,11 +210,11 @@ TEST(proc) {
if (pidref_is_kernel_thread(&pid) != 0)
continue;
cg_pid_get_path(SYSTEMD_CGROUP_CONTROLLER, pid.pid, &path);
cg_pidref_get_path(SYSTEMD_CGROUP_CONTROLLER, &pid, &path);
cg_pid_get_path_shifted(pid.pid, NULL, &path_shifted);
cg_pidref_get_owner_uid(&pid, &uid);
cg_pidref_get_session(&pid, &session);
cg_pid_get_unit(pid.pid, &unit);
cg_pidref_get_unit(&pid, &unit);
cg_pid_get_user_unit(pid.pid, &user_unit);
cg_pid_get_machine_name(pid.pid, &machine);
cg_pid_get_slice(pid.pid, &slice);