morgan/systemd
1
0
Fork 0
mirror of https://github.com/morgan9e/systemd synced 2026-04-14 08:25:20 +09:00
Code Issues Packages Projects Releases Wiki Activity

login/pam_systemd: use isatty_safe()

Browse Source 
Follow-up for d8069b8add
This commit is contained in:
Mike Yuan
2025-03-02 16:00:05 +01:00
parent f2b1de6f5b
commit ffabfef921
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/login/pam_systemd.c
View File

@@ -1604,7 +1604,7 @@ static int open_osc_context(pam_handle_t *handle, const char *session_type, User
* high-level for us, as it suffixes the output with a newline, expecting a full blown text message
* as prompt string, not just an ANSI sequence. Note that PAM's conv_misc() actually goes to stdout
* anyway, hence let's do so here too, but only after careful validation. */
if (!isatty(STDOUT_FILENO))
if (!isatty_safe(STDOUT_FILENO))
return PAM_SUCCESS;
/* Keep a reference to the TTY we are operating on, so that we can issue the OSC close sequence also
@@ -1688,7 +1688,7 @@ static int close_osc_context(pam_handle_t *handle) {
fd = fd_move_above_stdio(fd);
/* Safety check, let's verify this is a valid TTY we just opened */
if (!isatty(fd))
if (!isatty_safe(fd))
return PAM_SUCCESS;
_cleanup_free_ char *osc = NULL;