e582484789
udev's block device locking protocol has one pitfall not even the example in the documentation got right so far (even though this is explained in all detail above): udev's rescanning is only triggered when an fd that is opened for writing is closed. This means that if a separate locking fd is opened on a block device – one that is maintained independently of the fd actually used for writing – it must be opened for writing too, so that closing the lock definitely triggers a rescan. This matters in cases where the lock fd is kept for longer than the fd used for writing to disk. (Because otherwise udev might get the IN_CLOSE_WRITE event, but when it tries to rescan will find the device locked, and never retry because no IN_CLOSE_WRITE is triggred anymore.) Let's fix that across the codebase, at 4 places: 1. in makefs (a lock fd is kept, and mkfs then invoked as child, which uses a different fd, and the lock fd is closed only once the child died) 2. in udevadm lock (embarassing!): which is intended to be used to wrap tools that modify disk contents, very similar to the makefs case. The lock is also kept until after the tool exited. 3. In storagetm: the kernel nvme-tcp layer writes to the device directly, we just keep a lock fd. 4. the example in BLOCK_DEVICE_LOCKING.md
System and Service Manager
Details
Most documentation is available on systemd's web site.
Assorted, older, general information about systemd can be found in the systemd Wiki.
Information about build requirements is provided in the README file.
Consult our NEWS file for information about what's new in the most recent systemd versions.
Please see the Code Map for information about this repository's layout and content.
Please see the Hacking guide for information on how to hack on systemd and test your modifications.
Please see our Contribution Guidelines for more information about filing GitHub Issues and posting GitHub Pull Requests.
When preparing patches for systemd, please follow our Coding Style Guidelines.
If you are looking for support, please contact our mailing list, join our IRC channel #systemd on libera.chat or Matrix channel
Stable branches with backported patches are available in the stable repo.
We have a security bug bounty program sponsored by the Sovereign Tech Fund hosted on YesWeHack
Repositories with distribution packages built from git main are available on OBS