morgan/warehouse
1
0
Fork 0
mirror of https://github.com/morgan9e/warehouse synced 2026-04-14 00:04:08 +09:00
Code Issues Packages Projects Releases Wiki Activity

Make the add remote dialog HIG compliant

Browse Source
This commit is contained in:
Heliguy
2024-09-01 23:29:22 -04:00
parent 2b92514c9f
commit f2077d3cfe
2 changed files with 16 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/remotes_page/add_remote_dialog.blp
View File

@@ -3,24 +3,23 @@ using Adw 1;
template $AddRemoteDialog : Adw.Dialog {
title: _("Add a Remote");
content-width: 500;
content-height: 375;
// content-width: 500;
// content-height: 375;
width-request: 400;
follows-content-size: true;
Adw.ToolbarView {
[top]
Adw.HeaderBar {
}
[bottom]
ActionBar action_bar {
[center]
show-start-title-buttons: false;
show-end-title-buttons: false;
[start]
Button cancel_button {
label: _("Cancel");
}
[end]
Button apply_button {
margin-top: 3;
margin-bottom: 3;
sensitive: false;
styles ["pill", "suggested-action"]
Adw.ButtonContent {
icon-name: "plus-large-symbolic";
label: _("Add Remote");
}
styles ["suggested-action"]
label: _("Add");
}
}
Adw.ToastOverlay toast_overlay {

6
src/remotes_page/add_remote_dialog.py
View File

@@ -9,9 +9,9 @@ class AddRemoteDialog(Adw.Dialog):
__gtype_name__ = "AddRemoteDialog"
gtc = Gtk.Template.Child
action_bar = gtc()
toast_overlay = gtc()
stack = gtc()
cancel_button = gtc()
apply_button = gtc()
content_page = gtc()
title_row = gtc()
@@ -22,7 +22,6 @@ class AddRemoteDialog(Adw.Dialog):
def on_apply(self, *args):
self.stack.set_visible_child(self.loading_page)
self.apply_button.set_sensitive(False)
self.action_bar.set_revealed(False)
error = [None]
def thread(*args):
cmd = [
@@ -48,7 +47,6 @@ class AddRemoteDialog(Adw.Dialog):
def callback(*args):
if error[0]:
self.stack.set_visible_child(self.content_page)
self.action_bar.set_revealed(True)
self.apply_button.set_sensitive(True)
self.toast_overlay.add_toast(ErrorToast(_("Could not add remote"), str(error[0])).toast)
else:
@@ -104,6 +102,7 @@ class AddRemoteDialog(Adw.Dialog):
self.check_entries(self.title_row)
self.check_entries(self.name_row)
self.check_entries(self.url_row)
self.url_row.set_editable(False)
else:
self.title_row.set_editable(False)
self.name_row.set_editable(False)
@@ -111,6 +110,7 @@ class AddRemoteDialog(Adw.Dialog):
self.apply_button.set_sensitive(True)
# Connections
self.cancel_button.connect("clicked", lambda *_: self.close())
self.apply_button.connect("clicked", self.on_apply)
self.title_row.connect("changed", self.check_entries)
self.name_row.connect("changed", self.check_entries)