Armin Novak
f3d23da0ae
[codec,nsc] update function docs
...
* add doxygen for functions
* add support for scanline value 0
2026-02-17 09:15:33 +01:00
Armin Novak
169971607c
[codec,nsc] fix use of nsc_process_message
...
the second width/height argument should reflect the destination buffer
pixel size
2026-02-17 08:38:04 +01:00
Armin Novak
24a23e3028
[codec,nsc] deprecate nsc_decompose_message
...
this function is just a wrapper around nsc_process_message with some
wStream handling around it. Since proper length checks are missing
deprecate it completely.
2026-02-17 08:32:39 +01:00
Armin Novak
caf6e7f2ec
[codec,nsc] log decoder function parameter issues
2026-02-17 08:24:20 +01:00
akallabeth
9a382e67a2
Merge pull request #12315 from akallabeth/clear-check-fixup
...
[codec,clear] fix destination checks
2026-02-16 20:10:36 +01:00
Armin Novak
7d8fdce2d0
[codec,clear] fix destination checks
...
check against the correct nDstWidth/nDstHeight
2026-02-16 19:56:55 +01:00
akallabeth
341b52ad96
Merge pull request #12312 from akallabeth/planar-dst-fix
...
[codec,planar] fix missing destination bounds checks
2026-02-16 10:54:54 +01:00
Armin Novak
a0be5cb87d
[codec,planar] fix missing destination bounds checks
2026-02-16 10:00:23 +01:00
akallabeth
a25b90adc2
Merge pull request #12311 from akallabeth/winpr-attr-nodiscard-fkt-ptr
...
Winpr attr nodiscard fkt ptr
2026-02-16 09:32:52 +01:00
Armin Novak
a1c72a2f85
[server,warnings] properly handle function return
2026-02-16 09:18:39 +01:00
Armin Novak
f4b0549c5b
[client,warnings] properly handle function return
2026-02-16 09:18:38 +01:00
Armin Novak
bf99266c2e
[channels,warnings] properly handle function return
2026-02-16 09:18:38 +01:00
Armin Novak
e0e6a7f800
[freerdp,warnings] properly handle function return
2026-02-16 09:18:37 +01:00
Armin Novak
81cf9f6cf0
[winpr,warnings] properly handle function return
2026-02-16 09:18:36 +01:00
Armin Novak
93dc6b8691
[channels,tsmf] fix function misnaming
2026-02-16 09:18:36 +01:00
Armin Novak
13616cc67e
[freerdp,codec] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
9ecfb268fe
[freerdp,client] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
9d199a9735
[freerdp,server] mark function pointers [[nodiscard]]
2026-02-16 09:18:35 +01:00
Armin Novak
775ee2615a
[freerdp,channels] mark function pointers [[nodiscard]]
2026-02-16 09:18:34 +01:00
Armin Novak
6a1cc0f031
[freerdp,api] mark function pointers [[nodiscard]]
2026-02-16 09:18:30 +01:00
Armin Novak
399d92f26e
[winpr] mark function pointers [[nodiscard]]
2026-02-15 23:57:23 +01:00
akallabeth
a9e5642d69
Merge pull request #12310 from akallabeth/clear-fix
...
Clear fix bounds checks
2026-02-15 22:52:43 +01:00
Armin Novak
f4d74c33fd
[codec,nsc] bounds checks and doxygen
...
* Improve doxygen for nsc_process_message
* Improve bounds checks for nsc_process_message
2026-02-15 19:32:38 +01:00
akallabeth
6db1965bb2
Merge pull request #12309 from Wladefant/patch-1
...
[android] Fix invert scrolling default value mismatch
2026-02-15 19:21:27 +01:00
Armin Novak
0746639629
[codec,clear] fix missing destination boundary checks
2026-02-15 19:19:07 +01:00
Armin Novak
361d73bc0e
[core,settings] use WINPR_KBD_TYPE constants
...
To initialize FreeRDP_KeyboardType use WINPR_KBD_TYPE_IBM_ENHANCED
enum constant.
2026-02-15 19:18:54 +01:00
Wladimir Kirjanovs
31346e9024
[android] Fix invert scrolling default value mismatch
...
The `getInvertScrolling()` fallback default was `false`, while
the XML preference in `settings_app_ui.xml` defines `android:defaultValue="true"`.
On a fresh install, if `PreferenceManager.setDefaultValues()` has not yet
persisted the XML defaults into SharedPreferences, the fallback value
`false` is returned instead of the intended `true`. This causes the
"Invert Scrolling" option to appear checked in the UI but not actually
take effect until the user toggles it manually.
Change the fallback from `false` to `true` to match the XML default.
Fixes #12308
2026-02-15 18:25:28 +01:00
akallabeth
2de734ada0
Merge pull request #12306 from akallabeth/scard-pad-fix
...
[utils,smartcard] check stream length on padding
2026-02-15 14:00:25 +01:00
Armin Novak
65d59d3b3c
[utils,smartcard] check stream length on padding
...
When reading optional padding in smartcard channel check if padding is
actually there.
2026-02-15 11:34:59 +01:00
akallabeth
ffea8dd928
Merge pull request #12305 from akallabeth/sdl-monitor-fix
...
[client,sdl] fix move constructor of SdlWindow
2026-02-14 20:42:13 +01:00
Armin Novak
1ac24accf0
[client,sdl] fix move constructor of SdlWindow
2026-02-14 20:35:25 +01:00
akallabeth
0ff34a1124
Merge pull request #12217 from akallabeth/sdl-fs
...
Sdl fullscreen
2026-02-14 12:20:03 +01:00
akallabeth
e0d54eaf42
Merge pull request #12303 from akallabeth/sdl-pointer-fix
...
[client,sdl] improve cursor updates, fix surface sizes
2026-02-14 12:18:35 +01:00
Armin Novak
52cd988410
[client,sdl] fix cursor surface creation
...
* Pass the pixel width and height to SDL_CreateSurface
* Pass display scaled hotspot to SDL_CreateColorCursor
2026-02-14 10:06:12 +01:00
Armin Novak
3503be620a
[client,sdl] log cursor scale
2026-02-14 10:03:01 +01:00
Armin Novak
07bf4e9c10
[client,sdl] improve cursor updates
...
* use std::unique_ptr for temporary SDL_Surface (ease up cleanup)
* better logging of errors (add full surface details)
2026-02-14 10:02:57 +01:00
Armin Novak
1b577a755e
[client,sdl] add toString for SDL_Rect
2026-02-14 09:44:47 +01:00
akallabeth
28fc9a23a1
Merge pull request #12302 from akallabeth/x11-icon-fix
...
[codec,color] fix input length checks
2026-02-13 20:15:39 +01:00
Armin Novak
62c10e59d8
[client,android] fix platform dependent jlong size
...
always cast to int64_t to avoid format string issues.
2026-02-13 19:54:26 +01:00
Armin Novak
f5e20403d6
[codec,color] fix input length checks
...
* check cbBitsMask meets expected length
* Add logging for length failures
2026-02-13 19:39:21 +01:00
Armin Novak
da71c28c9c
[client,sdl] create a map of pixel coordinates
...
We need pixel coordinates for each monitor, but SDL may return logical
coordinates depending on HighDPI mode used by the system.
This commit does:
* Detect which HighDPI mode is in use isHighDPIWindowsMode
* Creates a map of pixel coordinates for each monitor
* recreated whenever a monitor changes)
* Updates the window rdpMonitor data for existing windows
2026-02-13 19:24:15 +01:00
akallabeth
3cb88eefd6
[client,sdl] detect displays on startup before RDP
...
do a simple display query on main SDL thread before starting RDP.
This way the required rdpMonitor details are already available when the
monitor layout or desktop resolution must be sent to the server
2026-02-13 19:24:15 +01:00
akallabeth
e2dd2eedab
[client,sdl] implement display detection handling
...
* SdlContext::detectDisplays to create a initial list of displays and
their rdpMonitor configuration
* SdlContext::getDisplays to query a SDL_DisplayID at runtime
* SdlContext::getDisplayIds to query available SDL_DisplayID at runtime
2026-02-13 19:24:15 +01:00
akallabeth
efa15e1dc2
[client,sdl] implement a static SdlWindow::query function
...
The display settings can not be proplerly queried by SDL without a
window. Create a temporary, invisible window for a requested monitor and
query the required details from that window.
2026-02-13 19:24:14 +01:00
akallabeth
99a44990ba
[client,sdl] rename SdlContext::removeDisplay
...
To match with SdlContext::addDisplayWindow rename it to
SdlContext::removeDisplayWindow
2026-02-13 19:24:10 +01:00
akallabeth
775e9e8576
Merge pull request #12301 from akallabeth/compiler-flags
...
[cmake,compiler] disable -Wjump-misses-init
2026-02-13 18:48:16 +01:00
Armin Novak
103964c7a6
[cmake,compiler] disable -Wc++-keyword
...
This is a C project, so C++ support is only required in public API
headers. Disable this warning.
2026-02-13 18:34:51 +01:00
Armin Novak
3af5581777
[cmake,compiler] disable -Wjump-misses-init
...
like explained in
https://lists.nongnu.org/archive/html/coreutils/2018-06/msg00044.html
this warning is quite useless for C (in contrast to C++) code
2026-02-13 18:22:33 +01:00
akallabeth
e28146d360
Merge pull request #12300 from akallabeth/sign-warnings
...
Sign warnings
2026-02-13 12:46:48 +01:00
Armin Novak
eb0b74a908
[channels,rdpecam] fix sign warnings
2026-02-13 12:17:47 +01:00